fix(engine): don't attempt search when ETS checkpoint is loading #308
+184
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkpoint file can be quite large (1.2G in my case) and it may take
quite a while to load it (8.2s in my case). During that time, all the
GenServer calls with the default timeout of 5000ms might timeout,
leading to the whole GenServer termination and general instability of
the search functionality.
This adds guards for state.loaded? which return {:error, :loading} if
it's not loaded.
Member
|
What is the result of adding these error return values? Does the editor display an error message? |
Contributor
Author
|
@mhanberg it is handled by the caller, like for example here: case Store.exact(subject, condition) do
{:ok, entries} ->
entries
_ ->
[]
endOne thing that could maybe be improved is to handle it inside call_or_default, but I'm not sure. What do you think? Either way, it's not visible to the editor. Client just gets an empty result set (and rightly so, I think, it's not an error - search index is simply not available at the moment). |
Member
|
Gotcha, I think it could be worth to keep the behavior as you have it but also post a window/showMessage notification that says the index is still loading. Or else to the user they think it's just not working. |
Contributor
Author
|
Added. Works in my tests. |
katafrakt
force-pushed
the
short-circuit-during-loading
branch
from
48e1882 to
7cc91da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkpoint file can be quite large (1.2G in my case) and it may take quite a while to load it (8.2s in my case). During that time, all the GenServer calls with the default timeout of 5000ms might timeout, leading to the whole GenServer termination and general instability of the search functionality.
This adds guards for state.loaded? which return {:error, :loading} if it's not loaded.
This addresses #303, probably only partially. I have more suspects of taking too long on a large project:
query_by_subjectduring delete (as described in Timeouts on querying search store #303)reducetakes 2-3 seconds for my project